-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cookbook): "Advanced Animations" cookbook recipe #586
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Non-blocking)
Noticed a small spelling mistake, so I thought I'd flag it:
goning
going
Thanks for working on this. It'll be great to have it!
Thanks @DennisSmuda for creating this PR and the base for multiple languages 💚. Really looking forward for this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DennisSmuda we would like to have this merge, could you please apply the suggestion and convert the PR to ready to review?
Hey @alvarosabu sorry I had trouble getting to it 🗡️ English + German looks good to me now 👍 |
Oh, hey! Will review soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! A few small changes.
The long comment is non-blocking, so feel free to ignore or just take the useful-to-you bits.
@andretchen0 I updated with your suggestions - thanks again ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
@alvarosabu : ready to merge?
I only did german + english. I could remove the recipe from the other languages first, or generate some content with ChatGPT 😄 |
Great work! I'm also a big fan of GSAP and I think there are many people should want to known how to make GASP work with Tres. @DennisSmuda I can review Chinese part if u want translate to other languages by LLM, or I can raise a PR for Chinese after this be merged |
Closes #477